libhv: update to v1.3.4 #8486

xflcx1991 · 2025-10-25T17:27:41Z

update libhv to v1.3.4

Summary by CodeRabbit

New Features
- Version v1.3.4 is now available.
Chores
- Updated package source retrieval mechanism for improved version handling.

coderabbitai · 2025-10-25T17:27:51Z

Walkthrough

Update to the libhv package manifest that modifies the archive URL pattern to reference tags and adds a new version entry v1.3.4 with its corresponding hash.

Changes

Cohort / File(s)	Summary
libhv xmake package configuration `packages/l/libhv/xmake.lua`	URL pattern updated from `archive/refs/$(version).zip` to `archive/refs/tags/$(version).zip` for versioned sources; new version v1.3.4 entry added with hash

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰✨ A libhv hop and a version so new,
v1.3.4 joins the tag-based brew,
Archive refs now point to the right place,
With a gentle update, we quicken the pace! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "libhv: update to v1.3.4" is directly aligned with the main change in the changeset, which adds version v1.3.4 with its corresponding hash and updates the archive URL pattern. The title is concise, specific, and clearly communicates the primary objective—updating the libhv package to version 1.3.4. A developer scanning the commit history would immediately understand the purpose of this change without ambiguity.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af695e2 and 772e88b.

📒 Files selected for processing (1)

packages/l/libhv/xmake.lua (2 hunks)

🔇 Additional comments (2)

packages/l/libhv/xmake.lua (2)

21-21: Confirm the SHA256 hash for v1.3.4 matches the official release.

The release v1.3.4 exists on GitHub (published 2025-10-25). The hash format is correct (valid SHA256). However, direct verification failed in the sandbox environment due to SSL certificate constraints. Please verify the hash independently using an external SHA256 tool or by checking against the official GitHub release.

7-7: URL pattern and v1.3.4 release are valid; hash verification limited by sandbox constraints.

The changes are verified as follows:

URL pattern change: The addition of /tags/ works correctly for all tested existing versions (v1.0.0, v1.2.6, v1.3.3) ✓

v1.3.4 release: The release exists on GitHub and is accessible (HTTP 200) ✓

Hash verification: Could not complete in sandbox due to SSL certificate constraints; however, the hash format is valid (64-character hex), and any mismatch would be caught by xmake during package installation

The changes appear correct and complete.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2025-10-25T17:27:52Z

Summary of Changes

Hello @xflcx1991, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the libhv library to its latest version, v1.3.4. This update ensures that the project benefits from the most recent features, bug fixes, and performance improvements provided by the libhv maintainers. Additionally, a minor but important correction was made to the source URL within the xmake.lua file to ensure proper fetching of the library's archive.

Highlights

Library Update: The libhv library has been updated to version v1.3.4.
Source URL Correction: The add_urls entry in xmake.lua was adjusted to correctly fetch the source archive by including /tags/ in the URL path.
Version Hash Added: The SHA-256 hash for libhv version v1.3.4 has been added to the xmake.lua configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist · 2025-10-25T17:32:47Z

Summary of Changes

Hello @xflcx1991, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the libhv package to its latest iteration, v1.3.4. Concurrently, it enhances the stability of the package's source code retrieval by adjusting the download URL to specifically target version tags on GitHub, ensuring that builds consistently use the intended release archives.

Highlights

Version Update: The libhv package has been updated to version v1.3.4.
Source Retrieval Mechanism: The package source URL has been refined to explicitly use GitHub tags (e.g., refs/tags/$(version).zip) for more reliable version fetching.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the libhv package to version v1.3.4. The changes include adding the new version and its hash, and also correcting the download URL for tagged releases. The URL format was changed to use .../refs/tags/$(version).zip, which is a critical fix as the previous format was incorrect for downloading versioned archives from GitHub. The changes are correct and well-implemented. I have no further suggestions.

gemini-code-assist

Code Review

This pull request updates the libhv package to version v1.3.4. The change correctly adds the new version and its hash. It also includes an important fix to the package's source URL to ensure it correctly downloads tagged releases from GitHub. I've added one suggestion regarding the ordering of versions for better maintainability. Overall, this is a good update.

gemini-code-assist · 2025-10-25T17:38:44Z

packages/l/libhv/xmake.lua

    add_versions("v1.3.1", "66fb17738bc51bee424b6ddb1e3b648091fafa80c8da6d75626d12b4188e0bdc")
    add_versions("v1.3.2", "61d6d5fadf13d81c111df4514e0e61062fead21c2a8b6c4caf7706f9b002fae1")
    add_versions("v1.3.3", "f78d1012ddf82506c28dda573ce303912e6cd5e707a358a249db1cc7e1e82238")
+    add_versions("v1.3.4", "966866873897ff4a7c526c3f6f1d00d7c13027aa5eef16270a5c5b4094dbdf95")


While adding the new version at the end of the list is functionally correct, for better maintainability and consistency across the repository, it's recommended to add new versions at the top of the add_versions block, keeping the list in descending order. This makes it easier for future maintainers to quickly identify the latest version.

xflcx1991 · 2025-10-26T02:44:14Z

@star-hengxing 求助，我看到windows平台静态链接的全部检查不通过，但是看不懂cmake报错，似乎是说找不到hv这个target

xflcx1991 · 2025-10-26T03:17:09Z

@star-hengxing 求助，我看到windows平台静态链接的全部检查不通过，但是看不懂cmake报错，似乎是说找不到hv这个target

哎呀呀，和v1.3.3相比，libhv加了这一段

Issues-translate-bot · 2025-10-26T03:17:23Z

Bot detected the issue body's language is not English, translate it automatically.

@star-hengxing Please help. I saw that all the checks for static links on the Windows platform failed, but I can’t understand the cmake error. It seems to mean that the hv target cannot be found.

Oops, compared with v1.3.3, libhv added this section

xflcx1991 · 2025-10-26T08:34:53Z

在上游也提了pr修改：ithewei/libhv#780

Issues-translate-bot · 2025-10-26T08:35:06Z

Bot detected the issue body's language is not English, translate it automatically.

PR modification has also been mentioned in the upstream: ithewei/libhv#780

gemini-code-assist bot reviewed Oct 25, 2025

View reviewed changes

libhv: update to 1.3.4

90f1b53

xflcx1991 force-pushed the update-libhv-1.3.4 branch from 772e88b to 90f1b53 Compare October 26, 2025 08:21

waruqi merged commit 16115e1 into xmake-io:dev Oct 26, 2025
61 checks passed

Uh oh!

libhv: update to v1.3.4 #8486

libhv: update to v1.3.4 #8486

Uh oh!

Conversation

xflcx1991 commented Oct 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

gemini-code-assist bot commented Oct 25, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot commented Oct 25, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

xflcx1991 commented Oct 26, 2025

Uh oh!

xflcx1991 commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Issues-translate-bot commented Oct 26, 2025

Uh oh!

xflcx1991 commented Oct 26, 2025

Uh oh!

Issues-translate-bot commented Oct 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xflcx1991 commented Oct 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 25, 2025 •

edited

Loading

xflcx1991 commented Oct 26, 2025 •

edited

Loading