openmvs: fix build

[choyy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @choyy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves build issues for the openmvs package by refining its xmake.lua configuration. The changes ensure more robust compilation across different operating systems, standardize versioning, and optimize dependency handling and linking processes, ultimately leading to a more stable and portable build environment for the library.

Highlights

• Build Configuration Updates: The xmake.lua file for the openmvs package has been updated to improve its build configuration and compatibility.
• Source URL and Versioning: The add_urls function now includes a direct Git repository URL, and the package version has been standardized to 'v2.3.0'.
• Platform-Specific Settings: The 'shared' library build configuration is now conditionally applied only for Windows platforms, and the on_install hook has expanded support to include Linux and macOS.
• Dependency Management: A version constraint (<5.0) has been added for the 'eigen' dependency to ensure compatibility.
• Linking Directives Refinement: The on_load function now globally adds linkdirs for lib/OpenMVS, removing redundant linking logic from the on_install block.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the openmvs package to improve its build process and extend platform support. The changes include updating URLs and versioning, restricting shared builds to Windows, adding a version constraint for the Eigen dependency, and making the on_load and on_install hooks more generic and cross-platform. These are all positive changes. However, I've identified a critical issue where the logic to add library links for consumers was removed but not replaced with a cross-platform alternative. This will likely break downstream projects. My review includes a suggestion to fix this.

[gemini-code-assist]

While extending on_install to support more platforms is correct, the logic for adding library links was removed from this block but not replaced with a cross-platform equivalent. This will likely cause linking errors for projects that depend on openmvs.

The original code was Windows-specific. Please add a cross-platform implementation inside the on_install block, after import("package.tools.cmake").install(package, configs). For example:

        -- Add library links for consumers
        local libdir = package:installdir("lib/OpenMVS")
        if os.isdir(libdir) then
            for _, name in ipairs(os.findlibs("*", {libdir})) do
                package:add("links", name)
            end
        end