-
-
Notifications
You must be signed in to change notification settings - Fork 488
Auto-update brpc to 1.15.0 #8475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to keep the project's dependencies up-to-date by automatically integrating the latest stable version of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update for the brpc package to version 1.15.0. While the new version and its hash have been correctly added, the update appears to be incomplete. Historically, this package has required patches for previous versions to ensure it builds correctly, but no patch has been added for 1.15.0. I've left a comment highlighting this potential issue, as it's likely to cause a build failure.
|
|
||
| add_urls("https://github.com/apache/brpc/archive/refs/tags/$(version).tar.gz") | ||
|
|
||
| add_versions("1.15.0", "f674b753af71dc313d9d2dcf34f574f0a3438c9f9bb9e7e6ca500a3b0ca7ddfb") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This automated update adds the new version of brpc, but it appears to be missing a required patch. Historically, nearly every version of brpc in this repository has needed a patch to address build issues, particularly with OpenSSL linkage.
The build is likely to fail without a patch for version 1.15.0.
The patch from version 1.14.1 might be reusable. If so, a line like the following should be added:
add_patches("1.15.0", path.join(os.scriptdir(), "patches", "1.14.1", "cmake.patch"), "04de26217d7fef37cf6e4d072cc65d767cf7d363b936d8cd652235be6f11e0c9")
New version of brpc detected (package version: 1.14.1, last github version: 1.15.0)