Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Oct 24, 2025

New version of brpc detected (package version: 1.14.1, last github version: 1.15.0)

@waruqi waruqi added the auto-update Automatic update label Oct 24, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to keep the project's dependencies up-to-date by automatically integrating the latest stable version of the brpc library. By adding the new version to the xmake.lua configuration, the build system can now correctly fetch and utilize brpc version 1.15.0, ensuring access to the latest features and bug fixes provided by the library.

Highlights

  • brpc Version Update: The brpc package definition has been updated to include version 1.15.0.
  • Checksum Added: A new add_versions entry with the corresponding SHA-256 checksum (f674b753af71dc313d9d2dcf34f574f0a3438c9f9bb9e7e6ca500a3b0ca7ddfb) has been added for brpc version 1.15.0 in the xmake.lua file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated update for the brpc package to version 1.15.0. While the new version and its hash have been correctly added, the update appears to be incomplete. Historically, this package has required patches for previous versions to ensure it builds correctly, but no patch has been added for 1.15.0. I've left a comment highlighting this potential issue, as it's likely to cause a build failure.


add_urls("https://github.com/apache/brpc/archive/refs/tags/$(version).tar.gz")

add_versions("1.15.0", "f674b753af71dc313d9d2dcf34f574f0a3438c9f9bb9e7e6ca500a3b0ca7ddfb")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This automated update adds the new version of brpc, but it appears to be missing a required patch. Historically, nearly every version of brpc in this repository has needed a patch to address build issues, particularly with OpenSSL linkage.

The build is likely to fail without a patch for version 1.15.0.

The patch from version 1.14.1 might be reusable. If so, a line like the following should be added:

add_patches("1.15.0", path.join(os.scriptdir(), "patches", "1.14.1", "cmake.patch"), "04de26217d7fef37cf6e4d072cc65d767cf7d363b936d8cd652235be6f11e0c9")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants