-
-
Notifications
You must be signed in to change notification settings - Fork 488
Auto-update sqlgen to v0.3.0 #8463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the new version v0.3.0 for the sqlgen package. I have added one comment on the new version line, highlighting two potential areas for improvement in the package definition related to platform support and patching. These changes would ensure the package remains robust and maintainable with this update.
| add_urls("https://github.com/getml/sqlgen/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/getml/sqlgen.git") | ||
|
|
||
| add_versions("v0.3.0", "f3a086e26a069f243265769831837d385986734458f52ed3aef06efddf03b3ac") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the addition of version v0.3.0, a couple of related points in this file may need updates for correctness and maintainability:
-
arm64support with PostgreSQL: Theon_checkblock (lines 36-40) currently prevents the use of this package onarm64when PostgreSQL support is enabled. If this limitation is resolved inv0.3.0, the check should be updated to apply only to older versions to enablearm64support for the new version. For example:on_check(function (package) if package:config("postgres") and package:version():lt("0.3.0") then assert(not package:is_arch("arm64"), "package(%s) does not support arm64 for versions < 0.3.0", package:name()) end end)
-
Patch for version
0.2.0: A patch is applied specifically for version0.2.0on line 12. If this patch is also required forv0.3.0, the version constraint foradd_patchesshould be updated (e.g., to"<0.4.0"). If the patch has been upstreamed and is no longer needed, no change is necessary.
Addressing these points will help ensure the new version is well-integrated and works correctly across all supported configurations.
New version of sqlgen detected (package version: v0.2.0, last github version: v0.3.0)