raylib: improve

[Willaaaaaaa]

some minor style improvement

[gemini-code-assist]

Summary of Changes

Hello @Willaaaaaaa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the raylib package definition within xmake.lua by incorporating the zlib license information and updating platform-specific build configurations. These changes improve the accuracy of the package metadata and ensure correct platform detection during the build process.

Highlights

• License Declaration: The zlib license has been explicitly added to the raylib package definition in xmake.lua, improving metadata completeness.
• Platform Detection Correction: Platform detection calls within the xmake.lua script have been updated from global is_plat functions to package:is_plat methods for wasm and android platforms, ensuring correct context-aware checks.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request includes changes to the xmake.lua file for the raylib package, adding a license and modifying platform checks. The addition of the license is a good practice. The platform check changes improve code clarity and maintainability.

[luadebug]

#8458 (comment)

If we use

if is_plat("windows", "linux", "macosx") then
    add_deps("opengl")
end

And keep add_deps("opengl", {optional = true}) would it resolve that issue?

[Willaaaaaaa]

i don't think so. But we can add checks (?):

if package:is_plat("windows", "linux", "macosx") then
    if not package:dep("opengl") then
        -- raise an error: plz install opengl
    end
end