eastl: update to 3.27.00 #8448
eastl: update to 3.27.00 #8448
Conversation
Summary of ChangesHello @a5ehren, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the EASTL library to its latest version, 3.27.00. A key part of this update involves adjusting the dependency resolution for EABase, where a direct commit hash and an alternative download method are introduced to acquire the necessary EABase version, circumventing the lack of a formal release tag. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates EASTL to version 3.27.00 and adds version 3.21.23. To support this, it also updates the eabase package by adding a new URL to fetch from a specific commit hash, as an official release tag is not available. The changes look good, but I have a minor suggestion to improve code formatting in the eabase package definition.
There was a problem hiding this comment.
OK, LGTM, altho it is obv better to follow .tar.gz pattern of link for .zip link. (as well as placing is_debug() instead of debug())
Besides .zip link would require to update SHA256 of each archive as SHA256 provided by .tar.gz would not match to .zip SHA256.
|
Cool. Though if the git thing works, then I shouldn't need the zip target anymore. |
packages/e/eastl/xmake.lua
Outdated
| io.replace("CMakeLists.txt", [[add_definitions(-D_CHAR16T)]], [[add_definitions(-D_CHAR16T) | ||
| if(BUILD_SHARED_LIBS) | ||
| target_compile_definitions(EASTL PUBLIC EA_DLL) | ||
| if(MSVC OR CYGWIN) |
There was a problem hiding this comment.
Well I was providing those changes, I think it should be WIN32 ?
3 participants
This also requires hacking an alternate URL to get the latest eabase, as EA has never released an updated tag for that.