Skip to content

aui: add new package #7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from
Open

aui: add new package #7686

wants to merge 24 commits into from

Conversation

luadebug
Copy link
Contributor

@luadebug luadebug commented Jul 19, 2025

Await for WebP iOS/NDK support -> #7687

@luadebug luadebug force-pushed the aui branch 2 times, most recently from b9cefca to d080553 Compare July 19, 2025 08:33
@luadebug luadebug force-pushed the aui branch 3 times, most recently from d8d6f3f to 245913b Compare July 19, 2025 15:06
"-DAUIB_DISABLE=ON"
}
if package:is_plat("windows") and package:is_arch("arm64") then
io.replace("cmake/aui.build.cmake", [[if (CMAKE_GENERATOR_PLATFORM MATCHES "(arm64)|(ARM64)" OR CMAKE_SYSTEM_PROCESSOR MATCHES "(aarch64|arm64)")]], [[if (1)]], {plain = true})
Copy link
Contributor Author

@luadebug luadebug Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules do not inherit -DCMAKE_SYSTEM_PROCESSOR=aarch64 or -DCMAKE_SYSTEM_PROCESSOR=arm64 that was passed into cmake cmd. Besides Ninja generator wont allow you to specify -DCMAKE_GENERATOR_PLATFORM=
Currently this is kind of workaround over this problem.

Comment on lines +70 to +79
- aui_link(aui.audio PUBLIC pulse)
+ if (AUIB_DISABLE)
+ auib_use_system_libs_begin()
+ find_package(PkgConfig)
+ pkg_check_modules(PULSEAUDIO REQUIRED IMPORTED_TARGET libpulse)
+ aui_link(aui.audio PUBLIC PkgConfig::PULSEAUDIO)
+ auib_use_system_libs_end()
+ else ()
+ aui_link(aui.audio PUBLIC pulse)
+ endif ()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to port pulseaudio itself as linux github CI could miss of that package preinstalled in the system.

Copy link
Contributor Author

@luadebug luadebug Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to port jack2 and later other ones
jack2 #7692

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

speex #7694

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulseaudio #7695

@luadebug luadebug changed the title aui: add new packgage aui: add new package Jul 20, 2025
@luadebug luadebug requested a review from star-hengxing July 22, 2025 20:14
@star-hengxing
Copy link
Contributor

Unbundle glm?

-- Installing: C:/Users/runneradmin/AppData/Local/.xmake/packages/a/aui/v7.1.2/3c93681861e540ee876554b737760d6a/aui.core/include//glm
-- Installing: C:/Users/runneradmin/AppData/Local/.xmake/packages/a/aui/v7.1.2/3c93681861e540ee876554b737760d6a/aui.core/include//glm/CMakeLists.txt
-- Installing: C:/Users/runneradmin/AppData/Local/.xmake/packages/a/aui/v7.1.2/3c93681861e540ee876554b737760d6a/aui.core/include//glm/common.hpp
-- Installing: C:/Users/runneradmin/AppData/Local/.xmake/packages/a/aui/v7.1.2/3c93681861e540ee876554b737760d6a/aui.core/include//glm/detail
-- Installing: C:/Users/runneradmin/AppData/Local/.xmake/packages/a/aui/v7.1.2/3c93681861e540ee876554b737760d6a/aui.core/include//glm/detail/compute_common.hpp
-- Installing: C:/Users/runneradmin/AppData/Local/.xmake/packages/a/aui/v7.1.2/3c93681861e540ee876554b737760d6a/aui.core/include//glm/detail/compute_vector_relational.hpp

This patch is too large, and future maintainers may not be able to understand it. We should report it upstream, or should we have one patch per component?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants