Skip to content

Conversation

@miredirex
Copy link
Contributor

@miredirex miredirex commented May 26, 2024

Changed assert because CefEnableHighDPISupport is gone

Summary by CodeRabbit

  • Chores
    • Updated C++ standard to C++17 for improved language feature support
    • Added support for CEF version 141.0.11 with corresponding checksums
    • Enhanced Windows build configuration with architecture-specific installation paths for x86 and x64 platforms
    • Updated test configuration for improved validation

@coderabbitai
Copy link

coderabbitai bot commented Oct 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the CEF package build configuration with two main changes: upgrading the C++ standard to C++17 and adding support for CEF version 141.0.11 with per-architecture Windows installation hooks and updated test assertions.

Changes

Cohort / File(s) Summary
C++ Standard Upgrade
packages/c/cef/port/xmake.lua
Updated cef_dll_wrapper target from C++14 to C++17
Version 141.0.11 Support
packages/c/cef/xmake.lua
Added version entry "141.0.11" to buildver mapping with corresponding Windows x64 and x86 checksums
Installation Hook Restructuring
packages/c/cef/xmake.lua
Refactored on_install hook from single "windows" target to per-architecture targets ("windows|x86", "windows|x64") with TODO comment for ARM support
Test Configuration Updates
packages/c/cef/xmake.lua
Changed test assertion from CefEnableHighDPISupport to CefShutdown and added languages = "c++17" configuration

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • The changes are primarily configuration and data updates with straightforward intent
  • Consider verifying the checksums for version 141.0.11 match expected values
  • Confirm the per-architecture installation hook logic correctly handles both x86 and x64 targets
  • Validate that the test switch from CefEnableHighDPISupport to CefShutdown aligns with testing requirements

Poem

🐰 C plus plus seventeen hops along,
New versions join the build-time song,
Windows paths both narrow and wide,
With checksums checksummed far and side,
The CEF package hops with delight! 🎉

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f8dbfc and 9d60627.

📒 Files selected for processing (2)
  • packages/c/cef/port/xmake.lua (1 hunks)
  • packages/c/cef/xmake.lua (4 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@miredirex miredirex closed this Oct 25, 2025
@miredirex miredirex deleted the cef-124-3-9 branch October 25, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant