Skip to content

Speed up validation #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Speed up validation #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad8ec46
only format message when errors are actually requested
mier85 Aug 4, 2020
507e997
revert go.mod changes
mier85 Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ func newError(err ResultError, context *JsonContext, value interface{}, locale l
details["context"] = context.String()
}

err.SetDescription(formatErrorDescription(err.DescriptionFormat(), details))
}

// formatErrorDescription takes a string in the default text/template
Expand Down
3 changes: 3 additions & 0 deletions result.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ func (v *Result) Valid() bool {

// Errors returns the errors that were found
func (v *Result) Errors() []ResultError {
for _, err := range v.errors {
err.SetDescription(formatErrorDescription(err.DescriptionFormat(), err.Details()))
}
return v.errors
}

Expand Down