Skip to content

Support #[coverage(off)] to exclude results #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Jul 29, 2024

The coverage_attribute feature has switched from no_coverage to coverage(off) in rust-lang/rust#114656.

This adds support for the new format.

I wasn't sure if the old format should be removed right away. It might need a deprecation first.

Closes #1591.

@xd009642
Copy link
Owner

I try to go rather conservative on deprecations, so if the compiler still supports #[no_coverage] then we'll keep it in. If it doesn't keep it in if it's low effort otherwise assess and decide

@zecakeh
Copy link
Contributor Author

zecakeh commented Jul 29, 2024

no_coverage is not supported anymore by the compiler.

@xd009642
Copy link
Owner

Cool we'll keep it in for now I'll just add a note about it after merge thanks for this looks good to me 👍

@xd009642 xd009642 merged commit e9a108c into xd009642:develop Jul 29, 2024
20 of 21 checks passed
@zecakeh zecakeh deleted the coverage-off branch July 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the new coverage(off) attribute format
2 participants