Skip to content

Conversation

@forman
Copy link
Member

@forman forman commented Mar 17, 2023

A new parameter extra_search_params has been added the CubeConfig as well as to the data store's open_data() method.

The value of extra_search_params is a dictionary that defines additional search parameters when querying the individual observations (time slices) that will form the data cube. Examples for such parameters are the keys "filter", "filter-lang", or "fields". More on this can be found in the Sentinel Hub Catalog API documentation.

Note that extra_search_params will be ignored if time_period is used
(i.e., given and not None).

Closes #93.

@forman forman requested a review from TonioF April 20, 2023 08:19
@forman forman self-assigned this Apr 20, 2023
@forman forman marked this pull request as ready for review April 20, 2023 08:19
Copy link
Contributor

@TonioF TonioF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two changes regarding the documentation requested. My biggest problem here is to validate it. Can you add a test or a notebook?

Co-authored-by: Tonio Fincke <tonio.fincke@brockmann-consult.de>
@forman forman requested a review from TonioF April 21, 2023 10:39
@TonioF
Copy link
Contributor

TonioF commented Apr 21, 2023

My biggest problem here is to validate it. Can you add a test or a notebook?

Can you still do this to show how to use this new parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query S1GRD via Track

3 participants