Mux mirror failure check for SXM #6439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
force-pushed
the
private/shul2/sxm-mux5
branch
5 times, most recently
from
eef608a to
71299b4
Compare
robhoes
approved these changes
May 1, 2025
|
Not sure what's going on with the CI... I can't seem to get it to rerun. |
Vincent-lau
force-pushed
the
private/shul2/sxm-mux5
branch
from
a5fb4ea to
71299b4
Compare
|
Vincent-lau
force-pushed
the
private/shul2/sxm-mux5
branch
from
71299b4 to
c973256
Compare
The current logic in storage_migrate.ml for mirror failure check is specific to tapdisk, hence multiplex it. `pre_deactivate_hook` also has something similar to check for mirror failure, so do something similar there. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Previously this was deleted in commit 1fe6389 as it was not multiplexed, but looks like we still need to keep it in storage_mux because sm-cli needs to make rpc calls to storage_mux when trying to list all the mirrors to make it work properly, due to the fact that the sr plugins are stored in the address space of the xapi process. There are other invocations in sm-cli such as `Storage_migrate.start` which may have similar problems. But I have left them alone as I don't any reasonable way of calling them from the cli. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Do the same as DATA.MIRROR.list Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Vincent-lau
force-pushed
the
private/shul2/sxm-mux5
branch
from
ea94a18 to
6de97ce
Compare
lindig
approved these changes
May 9, 2025
| ) | ||
| with | ||
| | Timeout elapsed -> | ||
| D.error |
There was a problem hiding this comment.
Do we need identifying information here like a VM to make this more useful?
| s.failed <- true | ||
| | e -> | ||
| D.error | ||
| "Caught exception while finally checking mirror state: %s" |
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Vincent-lau
force-pushed
the
private/shul2/sxm-mux5
branch
from
6de97ce to
bb994e0
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2025
This is a continuation of #6439 in the effort of implementing outbound SXM for SMAPIv3. We have reached the climatic point of this and can actually now implement the logic to do outbound SXM for SMAPIv3 SRs! This is a rather large PR and I expect it to take some time to be reviewed and merged, so I am opening this early to gather some feedback. Since #6439 is not yet merged and this PR depends on that one, I am marking this one as a draft, while reviewing please ignore the first three commit in this PR and look at #6439 first instead. I will update this one again when #6439 is merged There is also a couple of docs PR at the end documenting the design and approach taken in doing SMAPIv3 migration. In terms of testing plan, the important thing is to make sure for now that this is not regressing the SMAPIv1 migration. For that I will be using the SXM functional tests suite. I will also be using more tests to actually test the SMAPIv3 SXM feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #6434, more mutiplexing for SXM, this time the mirror status checking logic.
No functional change.
More to come...