Skip to content

Merge feature/guest-vm-service-aware into master #6407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

changlei-li
Copy link
Contributor

commit 2653f74 is new to update datamodel lifecycle

changlei-li and others added 12 commits February 18, 2025 16:24
Add a new field to store service aware data from guest vms

Signed-off-by: Changlei Li <changlei.li@cloud.com>
Add a new field to store service aware data from guest vms
1. xenopsd backend read and watch /local/domain/%d/data/service
2. xapi_guest_agent convert the data to (string, string) list
to store in VM_guest_metrics.services

Signed-off-by: Changlei Li <changlei.li@cloud.com>
Signed-off-by: Changlei Li <changlei.li@cloud.com>
…i-project#6317)

The field `VM_guest_metrics.services` added previously (xapi-project#6309) is used
to store VM service information reported by guest tools.
Xapi does not use this data but just holds it for outside consumers.
This PR reads the xenstore path `data/service` and converts to
`[("service_name/key", "value")]` pair list and then store to
VM_guest_metrics.services.
The path to read is like:
`/local/domain/<id>/data/service/<service_name>/<key> = <value>`
Signed-off-by: Changlei Li <changlei.li@cloud.com>
Signed-off-by: Changlei Li <changlei.li@cloud.com>
Conflict solved:
```
$ git diff
diff --cc ocaml/idl/schematest.ml
index b534f10,255e094e1..000000000
--- a/ocaml/idl/schematest.ml
+++ b/ocaml/idl/schematest.ml
@@@ -3,7 -3,7 +3,11 @@@ let hash x = Digest.string x |> Digest.
  (* BEWARE: if this changes, check that schema has been bumped accordingly in
     ocaml/idl/datamodel_common.ml, usually schema_minor_vsn *)

++<<<<<<< HEAD
 +let last_known_schema_hash = "34390a071f5df0fac8dcf9423a9111ae"
++=======
+ let last_known_schema_hash = "ad67a64cd47cdea32085518c1fb38d27"
++>>>>>>> master
```

Commit b6ced44 is new for updating
last_known_schema_hash and datamodel lifecycle
No conflict during merge. The code scanning warnings are introduced by
xapi-project#5995 , not relevant to this feature.
Sync master before merging to master. No confilct.
Signed-off-by: Changlei Li <changlei.li@cloud.com>
@minglumlu minglumlu added this pull request to the merge queue Apr 8, 2025
Merged via the queue into xapi-project:master with commit 790aa22 Apr 8, 2025
17 checks passed
@changlei-li changlei-li deleted the private/changleli/merge-feature-branch branch April 8, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants