-
Notifications
You must be signed in to change notification settings - Fork 292
Support qcow2 format in VDI export/import #6396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0647d38
[qcow-tool packaging] import qcow-tool from ocaml-qcow
gthvn1 c2621a6
[qcow-tool packaging] build fix: use io-page instead of io-page-unix
gthvn1 9bd40d4
[qcow-tool packaging] build fix: cstruct
gthvn1 def1cf6
[qcow-tool packaging] build fix: remove Unimplemented variant
gthvn1 81232c5
[qcow-tool packaging] build fix: update cmdliner
gthvn1 05b56c4
[qcow-tool packaging] package it in xapi
gthvn1 2f6c847
[qcow-tool packaging] remove lib-test
gthvn1 ecc0ee1
[qcow-tool] run make format
gthvn1 15f0f6e
[qcow-tool] add qcow as supported format
gthvn1 d77adf5
[qcow-tool] [WIP] implement streaming
gthvn1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,31 @@ | ||
(executable | ||
(name main) | ||
(public_name qcow-tool) | ||
(package qcow-tool) | ||
(libraries qcow io-page logs logs.fmt sha unix-type-representations | ||
cmdliner sexplib mirage-block-combinators) | ||
(preprocess | ||
(pps ppx_sexp_conv))) | ||
(name main) | ||
(libraries | ||
astring | ||
cmdliner | ||
cstruct | ||
cstruct-lwt | ||
fmt | ||
io-page logs | ||
logs.fmt | ||
lwt | ||
lwt.unix | ||
mirage-block | ||
mirage-block-unix | ||
mirage-block-combinators | ||
mirage-time | ||
qcow | ||
sexplib | ||
sha | ||
unix-type-representations | ||
) | ||
(preprocess | ||
(pps ppx_sexp_conv) | ||
) | ||
) | ||
|
||
(install | ||
(package qcow-tool) | ||
(section bin) | ||
(files (main.exe as qcow-tool)) | ||
) |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# This file is generated by dune, edit dune-project instead | ||
opam-version: "2.0" | ||
synopsis: "Manipulate .qcow files" | ||
maintainer: ["Xapi project maintainers"] | ||
authors: ["xen-api@lists.xen.org"] | ||
license: "LGPL-2.1-only WITH OCaml-LGPL-linking-exception" | ||
tags: ["org.mirage" "org:xapi-project"] | ||
homepage: "https://xapi-project.github.io/" | ||
bug-reports: "https://github.com/xapi-project/xen-api/issues" | ||
depends: [ | ||
"dune" {>= "3.15"} | ||
"asetmap" | ||
"astring" | ||
"cmdliner" | ||
"cstruct" | ||
"ezjsonm" | ||
"fmt" | ||
"io-page" | ||
"logs" | ||
"lwt" | ||
"mirage-block" | ||
"mirage-block-combinators" | ||
"mirage-block-unix" | ||
"mirage-time" | ||
"mirage-types-lwt" | ||
"ounit" | ||
"prometheus" | ||
"result" | ||
"sexplib" | ||
"sha" | ||
"unix-type-representations" | ||
"odoc" {with-doc} | ||
] | ||
build: [ | ||
["dune" "subst"] {dev} | ||
[ | ||
"dune" | ||
"build" | ||
"-p" | ||
name | ||
"-j" | ||
jobs | ||
"@install" | ||
"@runtest" {with-test} | ||
"@doc" {with-doc} | ||
] | ||
] | ||
dev-repo: "git+https://github.com/xapi-project/xen-api.git" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason you want to package it here? If it's going to be used as a library there's no need for this. For using the binaries in hosts, they can be generated as part of
xapi-tools
(so a change in the dune file)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason. I just follow what has been done (anyway as I think I understood how it was done with vhd-tool). And also as it looks like it was not maintained anymore so I did that. But yes I can also update the mirage package to compile and use it.