CA-408841: [XSI-1845] Enabling HA leads rrdd failure #6392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all dss in the current plugin are disabled, valuesandtransforms will be empty. In this case, will use the whole last_updated. Otherwise, use the per-datasource last_updated. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
|
I think it's better not to call ds_update at all in this particular case (it will be still called with reset values for all missing datasources for a particular plugin, so last_updated will be refreshed). There are other assumptions in place that could alter in-place data with such an empty refresh. |
|
Closed as there is another same PR: #6393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all dss in the current plugin are disabled, valuesandtransforms will be empty. In this case, will use the whole last_updated. Otherwise, use the per-datasource last_updated.