Skip to content

CA-407177: Fix swtpm's use of SHA1 on XS9 #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

rosslagerwall
Copy link
Contributor

The default crypto policy in XS9 disables use of SHA1. However, swtpm needs to use it since it advertises SHA1 support to guests. On XS9, swtpm will ship with a custom openssl configuration file for this purpose so set the appropriate environment variable to use it if the file exists.

The default crypto policy in XS9 disables use of SHA1. However, swtpm
needs to use it since it advertises SHA1 support to guests. On XS9,
swtpm will ship with a custom openssl configuration file for this
purpose so set the appropriate environment variable to use it if the
file exists.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
@rosslagerwall rosslagerwall force-pushed the private/rossla/CA-407177 branch from b53b1a8 to 8bafeda Compare March 19, 2025 17:15
@rosslagerwall
Copy link
Contributor Author

This is fine for XS8 too since there will be no change in behaviour if the .cnf file is not present.

Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. To protect against typos could assign the path to a variable and use it in the check and assignment.

@psafont psafont added this pull request to the merge queue Mar 20, 2025
Merged via the queue into xapi-project:master with commit c81536f Mar 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants