CP-54034: Expose expected_votes in Cluster object
#6374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Mar 19, 2025
| @@ -219,6 +219,9 @@ let t = | |||
| ; field ~qualifier:DynamicRO ~lifecycle:[] ~ty:Int "live_hosts" | |||
| ~default_value:(Some (VInt 0L)) | |||
| "Current number of live hosts, according to the cluster stack" | |||
| ; field ~qualifier:DynamicRO ~lifecycle:[] ~ty:Int "expected_hosts" | |||
| ~default_value:(Some (VInt 0L)) | |||
| "Total number of hosts expected by the cluster stack" | |||
There was a problem hiding this comment.
I'm not sure I understand the exact meaning of "expected by the cluster stack". Is that the amount of nodes that the cluster stack has been configured with?
There was a problem hiding this comment.
While I understand that it's useful to expose the information for debugging, the difference in semantics of these numbers is quite subtle.
There was a problem hiding this comment.
I'm not sure I understand the exact meaning of "expected by the cluster stack". Is that the amount of nodes that the cluster stack has been configured with?
Precisely
lindig
approved these changes
Mar 19, 2025
| @@ -219,6 +219,9 @@ let t = | |||
| ; field ~qualifier:DynamicRO ~lifecycle:[] ~ty:Int "live_hosts" | |||
| ~default_value:(Some (VInt 0L)) | |||
| "Current number of live hosts, according to the cluster stack" | |||
| ; field ~qualifier:DynamicRO ~lifecycle:[] ~ty:Int "expected_hosts" | |||
| ~default_value:(Some (VInt 0L)) | |||
| "Total number of hosts expected by the cluster stack" | |||
There was a problem hiding this comment.
While I understand that it's useful to expose the information for debugging, the difference in semantics of these numbers is quite subtle.
Vincent-lau
force-pushed
the
private/shul2/expected-votes
branch
from
0081355 to
076e7d8
Compare
Vincent-lau
force-pushed
the
private/shul2/expected-votes
branch
2 times, most recently
from
3ca42fe to
46a66c3
Compare
The `expected_votes` field in corosync represents the number of hosts that is expected by the cluster stack. In the context of corosync, this is the same as the number of hosts as in the corosync.conf file*. This is a useful field to expose to the user so that they can see how many nodes actually are expected. We also have `Cluster_host` object, which represents xapi's view of what nodes should be in the cluster, but that might not be identical to corosync's view, especially when a host is disabled, but is still left in the list of Cluster_host objects. Although one could argue that we could infer this `expected_votes` field from the number of enabled Cluster_hosts, it might still be useful to get this information directly from corosync. *: there are ways in corosync to make one host cast multiple votes, but that feature is not used. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
robhoes
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expected_votesfield in corosync represents the number of hosts that is expected by the cluster stack. In the context of corosync, this is the same as the number of hosts as in the corosync.conf file*. This is a useful field to expose to the user so that they can see how many nodes actually are expected.We also have
Cluster_hostobject, which represents xapi's view of what nodes should be in the cluster, but that might not be identical to corosync's view, especially when a host is disabled, but is still left in the list of Cluster_host objects.Although one could argue that we could infer this
expected_votesfield from the number of enabled Cluster_hosts, it might still be useful to get this information directly from corosync.*: there are ways in corosync to make one host cast multiple votes, but that feature is not used.