Skip to content

CA-408126 follow-up: Fix negative ds_min and RRD values in historical archives #6359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
+6 −2
Merged

CA-408126 follow-up: Fix negative ds_min and RRD values in historical archives #6359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ocaml/libs/xapi-rrd/lib/rrd.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,11 @@ let from_xml input =
let name = get_el "name" i in
let type_ = get_el "type" i in
let min_hb = get_el "minimal_heartbeat" i in
let min = get_el "min" i in
(* CA-408126 - work around negative data in historical RRDs
where ds_min could have been incorrectly set to neg_infinity.
Setting ds_min to 0. means Fring.make below will turn negative
historical values to NaNs.*)
let min = max (float_of_string (get_el "min" i)) 0. in
let max = get_el "max" i in
ignore (get_el "last_ds" i) ;
let value = get_el "value" i in
Expand All @@ -767,7 +771,7 @@ let from_xml input =
failwith "Bad format"
)
; ds_mrhb= float_of_string min_hb
; ds_min= float_of_string min
; ds_min= min
; ds_max= float_of_string max
; ds_last= VT_Unknown
; (* float_of_string "last_ds"; *)
Expand Down
Loading