CI: fix compile_commands.json caching #6356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the cache for compile_commands.json got reused we didn't install the OCaml compiler, which caused failures in the static analyzer, because it couldn't locate the compiler runtime headers. Do not skip setup-xapi-environment when the cache is reused. This could be optimized to skip installing dune packages (install just the compiler), but for now just install everything to avoid the error. Now when the cache is used we only skip installing/running dune-compiledb. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
psafont
approved these changes
Mar 12, 2025
We cannot skip the 'dune rules' part, because then files like xxhash_stubs.c will be missing because we haven't run the generators yet. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
|
Appears to work now, I've rerun the CI job, and looking at the Summary of the job it doesn't show the warning about the analyzer failure anymore, and there are some non-empty SARIF results too:CI run |
contificate
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cache for compile_commands.json got reused we didn't install the OCaml compiler, which caused failures in the static analyzer, because it couldn't locate the compiler runtime headers.
Do not skip setup-xapi-environment when the cache is reused.
This could be optimized to skip installing dune packages (install just the compiler), but for now just install everything to avoid the error.
Now when the cache is used we only skip installing/running dune-compiledb.