Skip to content

CA-403851 stop management server in Pool.eject () #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

CA-403851 stop management server in Pool.eject () #6346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ocaml/xapi/xapi_pool.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2074,6 +2074,8 @@ let eject_self ~__context ~host =
)
)
(fun () -> Xapi_fuse.light_fuse_and_reboot_after_eject ()) ;
debug "%s: stop management server" __FUNCTION__ ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be done earlier? It's not clear when calling this server being to be problematic, but it looks like it should be between unplugging PBDs (line 1875) and declaring itself ot be the master (line 2016)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think anything before the API call returns is reasonable; a client should not make any assumptions before the call returns.

Xapi_mgmt_iface.run ~__context ~mgmt_enabled:false () ;
Xapi_hooks.pool_eject_hook ~__context

(** eject [host] from the pool. This code is run on all hosts in the
Expand Down
Loading