CA-407564: Reintroduce try/with in Xapi_event #6345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A try-with was accidentally removed by a previous PR, causing failures when accumulating events for deleted objects. Signed-off-by: Colin James <colin.barr@cloud.com>
lindig
approved these changes
Mar 7, 2025
| else | ||
| events | ||
| events | ||
| with _ -> events |
There was a problem hiding this comment.
Do we want to log this? Might want to add a comment why they can be ignored and don't represent a problem.
There was a problem hiding this comment.
Maybe we want to log it when the kind is not del, when the kind is 'del' I think it is expected that find_get_record would fail.
There was a problem hiding this comment.
Or maybe this is happening on mod races, haven't been able to repro this through the python API, but booting/shutting down VMs in parallel causes XenCenter to lose connection quite often
Vincent-lau
approved these changes
Mar 7, 2025
|
We're going to revert the cleanup overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.