c_stubs: use 'new' acquire and release runtime functions #6341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions have a more relevant name than the previous ones, especially with the advent of OCaml 5.0 the runtime lock becomes more important and programmers must be aware of it. These functions were introduced in OCaml 3.12. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
contificate
approved these changes
Mar 6, 2025
last-genius
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Does not introduce any new problems so all good, but might just as well clean things up. I think @edwintorok has a pending PR doing this and more, but it hit some issues in testing, though.
Comment on lines
106
to
107
| const char* const hashed = | ||
| crypt_r(String_val(key), String_val(setting), &cd); |
There was a problem hiding this comment.
Not the fault of this (totally correct) commit, but these accesses to OCaml values should be brought out of this section.
| @@ -47,7 +47,7 @@ CAMLprim value stub_openfile_direct(value filename, value rw, value perm){ | |||
| flags |= O_RDONLY; | |||
| } | |||
| fd = open(filename_c, flags, Int_val(perm)); | |||
There was a problem hiding this comment.
Here and above with Bool_val too
| @@ -256,9 +256,9 @@ CAMLprim value stub_xenctrlext_physdev_map_pirq(value xch_val, | |||
| CAMLparam3(xch_val, domid, irq); | |||
| xc_interface *xch = xch_of_val(xch_val); | |||
| int pirq = Int_val(irq); | |||
| caml_enter_blocking_section(); | |||
| caml_release_runtime_system(); | |||
| int retval = xc_physdev_map_pirq(xch, Int_val(domid), pirq, &pirq); | |||
| @@ -269,9 +269,9 @@ CAMLprim value stub_xenctrlext_assign_device(value xch_val, value domid, | |||
| { | |||
| CAMLparam4(xch_val, domid, machine_sbdf, flag); | |||
| xc_interface *xch = xch_of_val(xch_val); | |||
| caml_enter_blocking_section(); | |||
| caml_release_runtime_system(); | |||
| int retval = xc_assign_device(xch, Int_val(domid), Int_val(machine_sbdf), Int_val(flag)); | |||
| @@ -281,9 +281,9 @@ CAMLprim value stub_xenctrlext_deassign_device(value xch_val, value domid, value | |||
| { | |||
| CAMLparam3(xch_val, domid, machine_sbdf); | |||
| xc_interface *xc = xch_of_val(xch_val); | |||
| caml_enter_blocking_section(); | |||
| caml_release_runtime_system(); | |||
| int retval = xc_deassign_device(xc, Int_val(domid), Int_val(machine_sbdf)); | |||
| @@ -299,9 +299,9 @@ CAMLprim value stub_xenctrlext_domain_soft_reset(value xch_val, value domid) | |||
| { | |||
| CAMLparam2(xch_val, domid); | |||
| xc_interface *xc = xch_of_val(xch_val); | |||
| caml_enter_blocking_section(); | |||
| caml_release_runtime_system(); | |||
| int retval = xc_domain_soft_reset(xc, Int_val(domid)); | |||
Then I think it's worth leaving the changes to that PR |
|
The Ocaml libraries in upstream Xen look like they need the same treatment. (We're going to need to take the plunge on Ocaml-5-ing them at some point) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions have a more relevant name than the previous ones, especially with the advent of OCaml 5.0 the runtime lock becomes more important and programmers must be aware of it.
These functions were introduced in OCaml 3.12.