-
Notifications
You must be signed in to change notification settings - Fork 292
CA-405864: Drop usage of init.d functions #6339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
init.d are from initscripts which are legacy and removed from XS9 This commit drop the usage of the scripts Signed-off-by: Lin Liu <Lin.Liu01@cloud.com>
ring3bst: 213725 (Dev Run) pass |
For some godforsaken reason, github won't show the warnings raised by shellcheck, even though it's able to upload the sarif report successfully. I'm looking into github's documentation to see what permission is missing (maybe pull_request: write), but it reeks of amateurism that the permission needed for each action is so hard to know. |
I can find the warnings here: https://github.com/xapi-project/xen-api/actions/runs/13666828406/job/38209665826?pr=6339 |
Yes, please. Unfortunately, we don't have a way to ignore a check |
The check does not block the merge, I will refine anyway. |
Signed-off-by: Lin Liu <Lin.Liu01@cloud.com>
5587706
to
118fd8e
Compare
ring3 bst looks good: 214371 (Dev Run) |
init.d are from initscripts which are legacy and removed from XS9 This commit drop the usage of the scripts