Skip to content

CA-405864: Drop usage of init.d functions #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

liulinC
Copy link
Collaborator

@liulinC liulinC commented Mar 5, 2025

init.d are from initscripts which are legacy and removed from XS9 This commit drop the usage of the scripts

init.d are from initscripts which are legacy and removed from XS9
This commit drop the usage of the scripts

Signed-off-by: Lin Liu <Lin.Liu01@cloud.com>
@liulinC
Copy link
Collaborator Author

liulinC commented Mar 5, 2025

ring3bst: 213725 (Dev Run) pass

@psafont
Copy link
Member

psafont commented Mar 5, 2025

For some godforsaken reason, github won't show the warnings raised by shellcheck, even though it's able to upload the sarif report successfully. I'm looking into github's documentation to see what permission is missing (maybe pull_request: write), but it reeks of amateurism that the permission needed for each action is so hard to know.

@liulinC
Copy link
Collaborator Author

liulinC commented Mar 6, 2025

For some godforsaken reason, github won't show the warnings raised by shellcheck, even though it's able to upload the sarif report successfully. I'm looking into github's documentation to see what permission is missing (maybe pull_request: write), but it reeks of amateurism that the permission needed for each action is so hard to know.

I can find the warnings here: https://github.com/xapi-project/xen-api/actions/runs/13666828406/job/38209665826?pr=6339
They are from existing code, I can fix some of it, but worrying about the regressions.

@psafont
Copy link
Member

psafont commented Mar 6, 2025

They are from existing code, I can fix some of it, but worrying about the regressions.

Yes, please. Unfortunately, we don't have a way to ignore a check

@liulinC
Copy link
Collaborator Author

liulinC commented Mar 7, 2025

  • At least 2 approving reviews are required by reviewers with write access.

Merge when ready

The check does not block the merge, I will refine anyway.

@liulinC liulinC changed the title CA-405864: Drop usage of init.d functions [WIP]CA-405864: Drop usage of init.d functions Mar 11, 2025
Signed-off-by: Lin Liu <Lin.Liu01@cloud.com>
@liulinC liulinC force-pushed the private/linl/init branch from 5587706 to 118fd8e Compare March 12, 2025 09:35
@liulinC liulinC changed the title [WIP]CA-405864: Drop usage of init.d functions CA-405864: Drop usage of init.d functions Mar 12, 2025
@liulinC
Copy link
Collaborator Author

liulinC commented Mar 12, 2025

ring3 bst looks good: 214371 (Dev Run)

@liulinC liulinC added this pull request to the merge queue Mar 13, 2025
Merged via the queue into xapi-project:master with commit 657aa71 Mar 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants