Skip to content

CA-407370: Use remote.conf for customer rsyslog forwarding rules #6328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

GeraldEV
Copy link

XenServer does not protect /etc/rsyslog.d/xenserver.conf when updating the rsyslog package (or the xenserver-release package on CH8.2CU1), as a result it is replaced with a fresh instance during updates which will lose customer configurations (if they have any).
This script is primarily invoked via XenCenter when providing a new host for log forwarding.
An update will be made to the XenServer rsyslog package to make it clear that /etc/rsyslog.d/xenserver.conf should not be edited by the customer.

I've tested this by copying the updated script onto my DT box and using XenCenter to add a new log server - noting the new /etc/rsyslog.d/custom.conf file and the untouched /etc/rsyslog.d/xenserver.conf file.

@GeraldEV GeraldEV force-pushed the private/geralde/CA-407370 branch 2 times, most recently from f81e0a6 to 275ba90 Compare February 27, 2025 16:21
@GeraldEV
Copy link
Author

Latest commit(s) to apply comment and make the script more tolerant (using -f)

@GeraldEV GeraldEV force-pushed the private/geralde/CA-407370 branch from 275ba90 to 48f8086 Compare February 27, 2025 16:48
@GeraldEV
Copy link
Author

Thanks for the comments, also spotted replacing the service as a result of the testing :D

@GeraldEV GeraldEV changed the title CA-407370: Use custom.conf for customer rsyslog forwarding rules CA-407370: Use remote.conf for customer rsyslog forwarding rules Feb 28, 2025
@GeraldEV GeraldEV requested a review from psafont March 5, 2025 20:46
Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@cloud.com>
@GeraldEV GeraldEV force-pushed the private/geralde/CA-407370 branch from e07e261 to 468eb75 Compare March 6, 2025 15:05
@GeraldEV
Copy link
Author

GeraldEV commented Mar 6, 2025

Squashed commits, waiting for builds before merging (re-tested just for sanity sake after the squash)

@robhoes robhoes added this pull request to the merge queue Mar 6, 2025
Merged via the queue into xapi-project:master with commit c75fd8b Mar 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants