-
Notifications
You must be signed in to change notification settings - Fork 292
CA-407370: Use remote.conf for customer rsyslog forwarding rules #6328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
robhoes
merged 1 commit into
xapi-project:master
from
GeraldEV:private/geralde/CA-407370
Mar 6, 2025
Merged
CA-407370: Use remote.conf for customer rsyslog forwarding rules #6328
robhoes
merged 1 commit into
xapi-project:master
from
GeraldEV:private/geralde/CA-407370
Mar 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f81e0a6
to
275ba90
Compare
Latest commit(s) to apply comment and make the script more tolerant (using -f) |
lindig
reviewed
Feb 27, 2025
275ba90
to
48f8086
Compare
Thanks for the comments, also spotted replacing the service as a result of the testing :D |
lindig
approved these changes
Feb 28, 2025
psafont
reviewed
Mar 3, 2025
robhoes
approved these changes
Mar 3, 2025
psafont
approved these changes
Mar 6, 2025
Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@cloud.com>
e07e261
to
468eb75
Compare
Squashed commits, waiting for builds before merging (re-tested just for sanity sake after the squash) |
rosslagerwall
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XenServer does not protect
/etc/rsyslog.d/xenserver.conf
when updating the rsyslog package (or the xenserver-release package on CH8.2CU1), as a result it is replaced with a fresh instance during updates which will lose customer configurations (if they have any).This script is primarily invoked via XenCenter when providing a new host for log forwarding.
An update will be made to the XenServer rsyslog package to make it clear that
/etc/rsyslog.d/xenserver.conf
should not be edited by the customer.I've tested this by copying the updated script onto my DT box and using XenCenter to add a new log server - noting the new
/etc/rsyslog.d/custom.conf
file and the untouched/etc/rsyslog.d/xenserver.conf
file.