Hugo docs: Support for dark themes: Invert images to match the theme #6284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I enabled Hugo theme selection (including dark themes) for the new Xapi docs,
we noted that images weren't properly adapted for the dark themes and that we could
fix these later. This PR fixes those minor problems when a dark theme is selected:
making them black-on-black in the dark themes.
the dark theme as well. This is also more friendly to dark theme users.
Addressed by:
It turns the the black foreground into white foreground on darker backgrounds.
removing the manual styling fixes makes the tables improves them in light and dark modes)
Dark themes, change it from black to white but then the text is not visible against bright gray.
As it currently does not work to use the grey shades from the theme in this case,
hard-code the text color to black. This fixes the contrast to keep the text visible.