CP-53470 Additional traces around xenopsd VM_migrate & rejoin traceparents in requests forwarded to xenopsd by xapi #6275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xs-aidan
force-pushed
the
private/aallen1/CP-50836
branch
from
cf535d2 to
077961f
Compare
|
updated DCO & ran ocamlformat |
|
I had no idea CI workflows "required approval from a maintainer" - I gave mine to see if everything passes here. |
|
To cover the entire body of a function with a |
lindig
approved these changes
Feb 5, 2025
|
discussed during standup that the PID changes could be split into a PR of its own. |
GabrielBuica
approved these changes
Feb 5, 2025
xs-aidan
force-pushed
the
private/aallen1/CP-50836
branch
from
077961f to
97c2305
Compare
Vincent-lau
reviewed
Feb 5, 2025
xs-aidan
commented
Feb 5, 2025
xs-aidan
force-pushed
the
private/aallen1/CP-50836
branch
from
97c2305 to
82890cc
Compare
|
latest trace available here: https://jaeger.kfd.eng.citrite.net/trace/695ffeb561c7ceaa9aa4e73302401a86?uiFind=151f83755d94c4d9 |
Vincent-lau
approved these changes
Feb 5, 2025
psafont
reviewed
Feb 5, 2025
psafont
reviewed
Feb 5, 2025
Signed-off-by: Aidan Allen <aidan.allen1@cloud.com>
Signed-off-by: Aidan Allen <aidan.allen1@cloud.com>
xs-aidan
force-pushed
the
private/aallen1/CP-50836
branch
from
82890cc to
6587b75
Compare
xs-aidan
changed the title
|
BVT + BST : 212301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconnected VM_receive_memory span to VM.migrate:
When xapi passes the traceparent header to xenopsd it is serialised under the additional_headers field of the json body, updated xenopsd to expect that instead of sourcing it from the non existent traceparent field
Added some additional spans around vm migration critical section including the specific point we receive the suspend from emu-manager/xenguest - this required moving the with_tracing function to a more common location