Added preprocessor directive so that the assembly internals are visib… #6245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc284
force-pushed
the
master
branch
2 times, most recently
from
13186cd to
356f134
Compare
…le to XenServerTest only when specified. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@cloud.com>
edwintorok
approved these changes
Jan 22, 2025
xueqingz
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le to XenServerTest only when specified.
Making the internals visible to a friend assembly works only if both assemblies are signed with a strong name or both unsigned. The code won't compile in scenarios where only the source code needs to be built and signed with a .snk key, therefore I'm suggesting using a preprocessor directive that can be switched on and off by the build caller (the other option is to put both source and test projects in a solution and build and sign both at all times, but at the moment I think we can go with the easy option).