Skip to content

CP-51701: xapi event optimizations #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2024
Merged

CP-51701: xapi event optimizations #6124

merged 4 commits into from
Nov 19, 2024

Conversation

edwintorok
Copy link
Contributor

Some low hanging fruit in Xapi_event:

  • List.map + any is the same as List.exists, but avoids constructing an intermediate list
  • the conversion to lowercase was done multiple times, even if the string was already lowercase. Checking that the string is already lowercase can be done a lot faster than converting (checking doesn't require allocation)

@edwintorok
CP-51701: [perf] Xapi_event: do not convert to lowercase if already l…
3225978 
…owercase

Tasks are lowercase

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
@edwintorok
CP-51701: [perf] Xapi_event: drop duplicate lowercase_ascii
e35d363 
Subscription.object_matches already does it

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
@edwintorok
CP-51701: [perf] Xapi_events: replace List.any+map with List.exists
9c1fc6e 
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
@edwintorok
CP-51701
7af12c1
@contificate contificate merged commit 4b86134 into xapi-project:feature/perf Nov 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psafont psafont psafont approved these changes

@contificate contificate contificate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwintorok @psafont @contificate