Skip to content

CA-401274: Remove external auth limitation during set_hostname_live #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

liulinC
Copy link
Collaborator

@liulinC liulinC commented Nov 18, 2024

Now we got winbind as the Active Direcotry backend, the joined netbios name is persisted in smb.conf, thus can be compatible with hostname change

This commit just remove the set_hostname_live limitation

@liulinC
Copy link
Collaborator Author

liulinC commented Nov 18, 2024

Test done:

When running winbind as the AD backend, it does not requires persistent hostname,

This is verified by @xihuan-citrix with XenRT job 27162041, e.g

Join domain
Verify AD function well
change hostname 
Verify AD function well
Revert hostname
Verify AD function well
In this case, we will remove this limitation from toolstack.

Now we got winbind as the Active Direcotry backend, the joined
netbios name is persisted in smb.conf, thus can be compatible with
hostname change

This commit just remove the set_hostname_live limitation

Signed-off-by: Lin Liu <Lin.Liu01@cloud.com>
@liulinC liulinC force-pushed the private/linl/hostname branch from 794b271 to 4222704 Compare November 18, 2024 07:52
@robhoes robhoes added this pull request to the merge queue Nov 18, 2024
Merged via the queue into xapi-project:master with commit 8d63a49 Nov 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants