CP-52114: Add pool.license_server for pool level licensing #6115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changlei-li
changed the title
changlei-li
force-pushed
the
private/changleli/CP-52114
branch
from
ca5cda3 to
7524b37
Compare
gangj
reviewed
Nov 18, 2024
gangj
approved these changes
Nov 18, 2024
minglumlu
reviewed
Nov 18, 2024
| ~key | ||
| ) | ||
| ~get_map:(fun () -> (x ()).API.pool_license_server) | ||
| () |
There was a problem hiding this comment.
I think a set_in_map would be useful as well.
There was a problem hiding this comment.
when set_in_map is not set, set_field will use remove_from_map then add_to_map to set map pair. So, command like xxe pool-param-set uuid=38abeb4c-7a61-7ef2-32a9-35e71cfb0fdf license-server:address=192.168.1.2 is already available.
changlei-li
force-pushed
the
private/changleli/CP-52114
branch
from
7524b37 to
be64aeb
Compare
Signed-off-by: Changlei Li <changlei.li@cloud.com>
changlei-li
force-pushed
the
private/changleli/CP-52114
branch
from
be64aeb to
901c2f7
Compare
minglumlu
approved these changes
Nov 18, 2024
robhoes
approved these changes
Nov 18, 2024
robhoes
merged commit b6ad9d1
into
xapi-project:feature/pool-licensing
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new XAPI pool level data for licensing