CA-401650: reduce open connections between pool members and the coordinator #6110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
force-pushed
the
private/edvint/connections
branch
from
92f6283 to
797b48a
Compare
psafont
reviewed
Nov 8, 2024
| @@ -42,9 +42,9 @@ type endpoint = {host: string; port: int} | |||
| (* Need to limit the absolute number of stunnels as well as the maximum age *) | |||
| let max_stunnel = 70 | |||
|
|
|||
| let max_age = 180. *. 60. (* seconds *) | |||
| let max_age = ref (180. *. 60.) (* seconds *) | |||
There was a problem hiding this comment.
More victims for my mtime changes :)
lindig
approved these changes
Nov 11, 2024
robhoes
reviewed
Nov 11, 2024
robhoes
reviewed
Nov 11, 2024
Vincent-lau
reviewed
Nov 11, 2024
This was referenced Nov 18, 2024
edwintorok
force-pushed
the
private/edvint/connections
branch
from
797b48a to
cd3ffc9
Compare
Previously it'd only run when we added or removed entries, but on an idle system we'd keep a large number of connections open that we don't need, and this then exceeded the connection limits on the coordinator. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Introduce separate coordinator_max_stunnel_cache and member_max_stunnel_cache settings, and set these on XAPI startup based on host role. No functional change, the defaults for both match the previous hardcoded value (70). Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/connections
branch
from
cd3ffc9 to
f9a523d
Compare
robhoes
approved these changes
Dec 3, 2024
edwintorok
pushed a commit
to edwintorok/xen-api
that referenced
this pull request
Dec 10, 2024
…inator (xapi-project#6110) The GC timers in the stunnel cache were ineffective because we hardly ever run this GC code, and also because the maximums were very large (70+).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GC timers in the stunnel cache were ineffective because we hardly ever run this GC code, and also because the maximums were very large (70+).