CA-399629: make daily-license-check aware of never #6104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contificate
approved these changes
Nov 6, 2024
lindig
approved these changes
Nov 6, 2024
| let serialize_expiry = function | ||
| | None -> | ||
| "never" | ||
| | Some date when Date.equal date never -> |
There was a problem hiding this comment.
Should we test for date >= never?
There was a problem hiding this comment.
technically, only that timestamp is supposed to be never
psafont
force-pushed
the
late-licenses
branch
2 times, most recently
from
6b174ee to
f3bf203
Compare
The license field is not always a valid date, sometimes it contains a special value to signify there's no expiry date. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Internalize the concept of expiration dates, including "never", and use Date to manage all the dates, instead of using unix time Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This now matches the concept of xenserver's licensing daemon, which changed it in the last year. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Instead use the Date, Ptime and Ptime.Span Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
psafont
force-pushed
the
late-licenses
branch
from
f3bf203 to
7db5e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license field is not always a valid date, sometimes it contains a special
value to signify there's no expiry date.