Skip to content

Corrected strings. #6024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Corrected strings. #6024

merged 1 commit into from
Oct 1, 2024

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Sep 30, 2024

I noticed these when I dropped the latest SDK into XC.

Copy link
Member

@robhoes robhoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you probably need to update the schema test hash.

@kc284
Copy link
Contributor Author

kc284 commented Sep 30, 2024

Yeah, the format too...

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@cloud.com>
@kc284
Copy link
Contributor Author

kc284 commented Oct 1, 2024

@robhoes I don't see any test failures that might warrant a schema test hash change, after I fixed the format all checks are passing.

@kc284 kc284 added this pull request to the merge queue Oct 1, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 1, 2024
I noticed these when I dropped the latest SDK into XC.
@psafont psafont removed this pull request from the merge queue due to a manual request Oct 1, 2024
@psafont
Copy link
Member

psafont commented Oct 1, 2024

We have broken CI internally right now, please hold the merge until it's resolved

@kc284
Copy link
Contributor Author

kc284 commented Oct 1, 2024

Ok, sorry!

@psafont psafont added this pull request to the merge queue Oct 1, 2024
Merged via the queue into xapi-project:master with commit 2f251e1 Oct 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants