Skip to content

Do not assume IPv4 when disabling management #6012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Do not assume IPv4 when disabling management #6012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ocaml/xapi/xapi_host.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,7 +1303,11 @@ let management_disable ~__context =
raise
(Api_errors.Server_error (Api_errors.slave_requires_management_iface, [])) ;
(* Reset the management server *)
Xapi_mgmt_iface.change "" `IPv4 ;
let management_address_type =
Record_util.primary_address_type_of_string
Xapi_inventory.(lookup _management_address_type)
in
Xapi_mgmt_iface.change "" management_address_type ;
Xapi_mgmt_iface.run ~__context ~mgmt_enabled:false () ;
(* Make sure all my PIFs are marked appropriately *)
Xapi_pif.update_management_flags ~__context
Expand Down
Loading