CP-47509: Revisited the setting of response headers to avoid errors when multiple threads use the same session object #5990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
previously approved these changes
Sep 13, 2024
|
Forced-pushed because I had forgotten to sign the commit. |
contificate
previously approved these changes
Sep 13, 2024
…hen multiple threads use the same session object. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@cloud.com> Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
danilo-delbusso
force-pushed
the
master
branch
from
73d2b03 to
f8a5f49
Compare
danilo-delbusso
requested review from
edwintorok,
MichaelSabin-Citrix and
contificate
danilo-delbusso
dismissed stale reviews from contificate and edwintorok
stale
danilo-delbusso
changed the title
danilo-delbusso
approved these changes
Sep 16, 2024
edwintorok
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
This improves backwards compatibility with old code that was using this SDK.
If the code wants to access the new response headers field it'll need to create one object per thread, however code that doesn't access those headers should keep working without raising exceptions (the last write to the field would win).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.