CA-397599 XSI-1704 #5984
Merged
CA-397599 XSI-1704 #5984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lindig
commented
Sep 12, 2024
lindig
commented
robhoes
reviewed
Sep 12, 2024
ocaml/idl/datamodel_vm.ml
Outdated
| (Ref _vm, "self", "The VM") | ||
| ; (Map (operations, String), "value", "Blocked operations") | ||
| ] | ||
| ~allowed_roles:_R_VM_OP (* was unrestricted when auto-generated? *) |
There was a problem hiding this comment.
These we _R_VM_ADMIN, owing to the default for the class set at the create_obj call.
~messages_default_allowed_roles:_R_VM_ADMIN
So that was a little stricter than VM_OP.
There was a problem hiding this comment.
Will change that to VM_ADMIN.
last-genius
approved these changes
Sep 13, 2024
lindig
force-pushed
the
private/christianlin/CA-397599
branch
from
1c88b9a to
d95bc12
Compare
Vincent-lau
approved these changes
Sep 13, 2024
|
@Vincent-lau The reason I split out the hash is that this should simplify back porting as this hash will conflict. In practice there are more problems with back porting. |
added 2 commits
September 16, 2024 10:17
Currently the setter for field VM.blocked_oeprations is auto generated. Implement this explicitly such that we can update allowed operations which currently is not happening. Allowed operations are used by XenCenter to disable operations; this has led to operations becoming unavaliable because allowed operations where not aligned with blocked operations when blocked operations were updated. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
lindig
force-pushed
the
private/christianlin/CA-397599
branch
from
d95bc12 to
7d6d88e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.