Plugin openvswitch-config-update: fix python2ism in python3 migration
#5918
Conversation
PR xapi-project#5261 made the switch to python3 but missed a dict.itervalues() call, which causes a failure with python3. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
There was a problem hiding this comment.
@edwintorok AFAICS, the openvswitch-config-update plugin will crash due to this bug on XS8.
The condition this may be hit would be when attempting to replace the SDN controller returned by session.xenapi.SDN_controller.get_all()[0] at at the beginning of the update function with a different SDN controller
I don't know how often that happens but as it apparently may have hit, I would assume and agree with @ydirson that this is material that should be released as an XS8 bugfix.
Further information:
- Some info on this change in Py3: https://peps.python.org/pep-0469/
2to3applies the same fix and it is needed.
In general:
- I ran
2to3 -x printto get a somewhat reviewable list of potential similar missed conversions in thepython3directory, and found no other similar not applied conversion done by2to3using this method.
bernhardkaindl
changed the title
openvswitch-config-update: fix python2ism in python3 migration
|
What's the plan for XS8? Does it target following the 24.x line, or is a specific backport needed? |
|
All commits currently end up in XS8. At some point, an LCM (LTSR) branch will be created for it, which is when it will need backports. |
PR #5261 made the switch to python3 but missed a dict.itervalues() call, which causes a failure with python3.
Should also be backported for XS8.