CP-46933: Expose XAPI API version in the output of HTTP API /updates #5886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a build failure: |
gangj
commented
Jul 30, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion
a discussion (no related file):
Enable reviewable
gangj
force-pushed
the
private/gangj/CP-46933
branch
from
6aaaec0 to
b9f8c0c
Compare
lindig
approved these changes
Jul 30, 2024
gangj
changed the title
gangj
force-pushed
the
private/gangj/CP-46933
branch
from
b9f8c0c to
5953bb4
Compare
minglumlu
reviewed
Aug 6, 2024
minglumlu
reviewed
Aug 6, 2024
minglumlu
reviewed
Aug 6, 2024
gangj
force-pushed
the
private/gangj/CP-46933
branch
2 times, most recently
from
6a367e2 to
e3e605b
Compare
XAPI API version is exposed from updateinfo.xml, to expose it in the output of HTTP API /updates, a new json field "xapi-api-version" is added in the json output only when XAPI API version is exposed from updateinfo.xml successfully, otherwise the returned json data keeps the original format. Signed-off-by: Gang Ji <gang.ji@citrix.com>
gangj
force-pushed
the
private/gangj/CP-46933
branch
from
e3e605b to
c5918fa
Compare
minglumlu
approved these changes
Aug 7, 2024
gangj
merged commit 784ddee
into
xapi-project:feature/update-backwards-compat
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XAPI API version is exposed from updateinfo.xml, to expose it in the output of HTTP API /updates, a new json field "xapi-api-version" is added in the json output only when XAPI API version is exposed from updateinfo.xml successfully, otherwise the returned json data keeps the original format.
This change is