CP-50448: run quickcheck tests in XenRT #5884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
force-pushed
the
private/edvint/ci-to-quicktest
branch
from
c2a8323 to
191efc4
Compare
|
Testing has passed, although this PR might conflict with other open PRs, and may require a rebase, e.g. #5885 |
edwintorok
force-pushed
the
private/edvint/ci-to-quicktest
branch
2 times, most recently
from
7600ff8 to
c2a8323
Compare
|
The last 2 commits are not ready yet, removed from here: if we exit there then we no longer call 'finish' that looks for leaks. |
edwintorok
force-pushed
the
private/edvint/ci-to-quicktest
branch
from
c2a8323 to
80211b5
Compare
We want to run these from 'quicktest', so make them available as libraries, and add a _run.ml that would run them separately, just as before. (running separately in the CI is better, because it can be parallelize) No functional change. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/ci-to-quicktest
branch
2 times, most recently
from
172e180 to
4a8a715
Compare
Quicktest runs in Dom0, and the existing quickcheck tests run in the CI. Some of these test as much the OCaml code, as its interaction with the system (e.g. behaviour of system calls). So it is better to run these tests both in the CI and in Dom0. We run these in long mode, to explore more randomly generated scenarios. The seed can be controlled with QCHECK_SEED environment variable. Similar to @StressTest it uses a random seed, instead of a fixed seed. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/ci-to-quicktest
branch
from
4a8a715 to
efcb7af
Compare
|
#5885 is merged, I rebased this one, and dropped the 'qcheck_alcotest.ml', since we now use the upstream lib directly. |
psafont
approved these changes
Jul 29, 2024
lindig
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending testing, draft PR.
Takes about 24s to run manually: