maintenance: delete unused fields #5880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are errors in dune 3.15 and don't seem to be problematic Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
edwintorok
reviewed
Jul 24, 2024
edwintorok
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
I've got a branch which begins using span_link, but we probably need to implement an exporter for it.
Perhaps for now instead of deleting we could comment out the span link code, so we can easily reenable it when we implement the exporter. I'll open a ticket to implement it.
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
lindig
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are errors in dune 3.15 and don't seem to be problematic
The warnings in tracing have been left in the code, but need to be dealt with
They are span links and description for the status. Currently they are unused. @GabrielBuica is there any work in the pipeline planned for this? I'd like to readd the warning as an error