CP 49214: Upload and reposync from the bundle #5851
Conversation
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
46b9c6b to
c4d58e9
Compare
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
c4d58e9 to
710d8a8
Compare
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
4 times, most recently
from
4e83d4b to
fd0a796
Compare
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
fd0a796 to
4ef1f95
Compare
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
4ef1f95 to
9c46d5c
Compare
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
9c46d5c to
550c3d8
Compare
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
550c3d8 to
be17cdd
Compare
|
There is an existing issue. Uploading an incomplete file will lead the TCP connection hanging. VM_import has the same issue. |
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
be17cdd to
60495b9
Compare
Upload a bundle file and unpack it with module Tar_ext. After that, sync the bundle repository. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
Add an allowed_operations for sync bundle. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
60495b9 to
2609fa9
Compare
1. Replace all `Client.Pool.get_all` and `Client.Pool.get_master` with self-defined function `cli_util.get_pool` and `cli_util.get_master` so that we can reduce the use of `List.hd`. 2. Remove some unused getting pool_master code in function `host_careful_op`. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
BengangY
force-pushed
the
private/bengangy/CP-49214
branch
from
2609fa9 to
c870b26
Compare
| @@ -51,13 +51,16 @@ let introduce ~__context ~name_label ~name_description ~binary_url ~source_url | |||
| let introduce_bundle ~__context ~name_label ~name_description = | |||
There was a problem hiding this comment.
This was probably introduced in a different PR, but I've downloaded the generated SDK from the github actions of the current PR and the release info for repository.introduce_bundle is 1.301.0, which looks like a copy-paste error from repository.introduce.
There was a problem hiding this comment.
This is a build issue. The reason is below:
The release info is based on a field lifecycle in the code. As the code is still in review and being tested, we don't know what value should it be, so the lifecycle is kept empty.
After the code is merged into the feature branch and the testing is finished, we will then merge the code into the master branch. At this time point, we will change the lifecycle to the actual release info such as 24.23.0.
For the koji build, it will execute make build first (if the lifecycle is empty, it will auto-fill a temporary value such as 24.21.0-next into lifecycle), and then execute make sdk to generate the SDK.
But for the PR build, make build and make sdk are executed concurrently, so the lifecycle is still empty when the SDK is generated, this leads the release info to be an old previous version number.
The koji-built SDK doesn't have this issue, you can download from here which is built based on this PR this morning.
https://koji.eng.citrite.net/kojifiles/repos/pb-t_bengangy-non-cdn/231372/x86_64/toplink/packages/xapi/24.21.0.17.gc870b266b/1.2.g8796faa.xs8/noarch/xapi-sdk-24.21.0.17.gc870b266b-1.2.g8796faa.xs8.noarch.rpm
As this issue only reproduce with a bad bundle file by an authorized user, and can be resolved by cancelling the bundle syncing from xe client, and as we are targeting for feature branch, I think we can merge it for now and have more investigation and discussion later. |
Upload a bundle file and unpack it with module Tar_ext. After that, sync the bundle repository.