Skip to content

CP-49919: mv scripts/extensions/pool_update.precheck to python3/extensions #5805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024
Merged

CP-49919: mv scripts/extensions/pool_update.precheck to python3/extensions #5805

merged 1 commit into from
Jul 11, 2024

Conversation

ashwin9390
Copy link
Contributor

Main ticket CP-49100 :Move python3 scripts from scripts directory to python3 directory.

Sub task CP-49919:

  • Modified python3/Makefile to include pool_update.precheck
  • Removed pool_update.precheck from scripts/Makefile
  • Added necessary methods in stubs/XenAPI.py to fix pyright issue
  • Initialized variable to fix reportPossiblyUnboundVariable

Signed-off-by: Ashwinh ashwin.h@cloud.com

…sions

Original (code supplied) by Bernhard Kaindl:
- Declare missing methods to python3/stubs/XenAPI.py for pyright
- Initialize variables to fix pyright:reportPossiblyUnboundVariable
- Applied isort

Signed-off-by: Ashwinh <ashwin.h@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Copy link
Collaborator

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the commit message to reflect that I provided the fixes.

@bernhardkaindl bernhardkaindl changed the title CP-49919: Moved pool_update.precheck from scripts/extensions to python3 extensions CP-49919: mv scripts/extensions/pool_update.precheck to python3/extensions Jul 11, 2024
@bernhardkaindl bernhardkaindl merged commit 160ef6d into xapi-project:feature/py3 Jul 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants