Skip to content

CP-49928 static-vdis: Fix pyright: Add type hints, assert, var = "" #5769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ashwin9390
Copy link
Contributor

@ashwin9390 ashwin9390 commented Jul 2, 2024

Main ticket CP-49100: Move python3 scripts from scripts directory to python3 directory.

Subtask CP-49928:

  • Add type hints for pyright

Author: Signed-off-by: Bernhard Kaindl bernhard.kaindl@cloud.com

Committed by :Signed-off-by: Ashwinh ashwin.h@cloud.com

@bernhardkaindl bernhardkaindl force-pushed the static-vdis-pyright-type-hints branch 3 times, most recently from 0402b49 to e8de3f4 Compare July 2, 2024 16:15
@bernhardkaindl bernhardkaindl changed the title CP-49928:static-vdis: Add type hints for pyright CP-49928 static-vdis: Fix pyright: Add type hints, assert, var = "" Jul 2, 2024
@bernhardkaindl bernhardkaindl changed the title CP-49928 static-vdis: Fix pyright: Add type hints, assert, var = "" CP-49928 static-vdis: Fix pyright: Add type hints, assert, var = "" Jul 2, 2024
@bernhardkaindl bernhardkaindl force-pushed the static-vdis-pyright-type-hints branch 4 times, most recently from 9f2fd64 to ebdd018 Compare July 2, 2024 17:32
@bernhardkaindl bernhardkaindl requested a review from psafont July 2, 2024 17:32
@bernhardkaindl bernhardkaindl force-pushed the static-vdis-pyright-type-hints branch 2 times, most recently from 53a5ba3 to c69aa04 Compare July 3, 2024 02:22
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl force-pushed the static-vdis-pyright-type-hints branch from c69aa04 to f68e897 Compare July 3, 2024 02:30
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be properly unit-tested. Coverage wasn't uploaded because of codecov shenanigans

@psafont psafont merged commit 5fd8cf7 into xapi-project:feature/py3 Jul 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants