CP-49916: Moved perfmon, perfmon.service and sysconfig-perfmon from scripts/ to python3/perfmon directory #5767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Jul 2, 2024
psafont
reviewed
Jul 2, 2024
…cripts/ to python3/perfmon directory - Modified Makefile to include these changes. - Removed perfmon, perfmon.service and sysconfig-perfmon from scripts/Makefile Signed-off-by: Ashwinh <ashwin.h@cloud.com>
psafont
approved these changes
Jul 2, 2024
bernhardkaindl
approved these changes
Jul 2, 2024
stephenchengCloud
added a commit
to stephenchengCloud/xen-api
that referenced
this pull request
Jul 24, 2024
When testing the feature/py3 branch, xapi failed to restart due to perfmon.service not loaded. The root cause is that: In this PR: xapi-project#5767, we moved perfmon.service from `scripts/Makefile` to `python3/Makefile` In `scripts/Makefile`, `IPROG` is defined as: IPROG=./install.sh 755 IDATA=./install.sh 644 While in `python3/Makefile`, `IPROG` is defined as: IPROG=install -m 755 IDATA=install -m 644 And the purpose of `install.sh` is to replace strings in *.service like: @OPTDIR@ -> ${OPTDIR} So in python3/Makefile, we didn't replace these strings, and then led to the error. Signed-off-by: Stephen Cheng <stephen.cheng@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main ticket CP-49100 :Move python3 scripts from scripts directory to python3 directory.
Sub task CP-49916:
Signed-off-by: Ashwinh ashwin.h@cloud.com