CI: Update endcover step to v2 to fix CI #5763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
update-endcover-to-v2
branch
from
817dae5 to
3f0690a
Compare
psafont
approved these changes
Jul 2, 2024
bernhardkaindl
requested review from
lindig,
snwoods,
contificate and
danilo-delbusso
lindig
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this update to
coverallsapp/github-action@v2(the existing uses ofcoverallsapp/github-actionalso usev2) is expected to fix the CI failure @edwintorok saw in #5761 (comment).Also added:
continue-on-error: true(already used in other steps before) to not failCI.
name:to the new step to complete the coveralls upload so it shows in the GitHub workflow graph and on the "Checks:" with a proper name.Checked: Fixed the builds to no longer be in status "pending completion" on https://coveralls.io/github/xapi-project/xen-api