Some OCaml 5 build fixes #5755
Merged
Some OCaml 5 build fixes #5755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/deprecated
branch
from
82fb390 to
f226aaa
Compare
psafont
reviewed
Jul 1, 2024
| @@ -48,7 +48,7 @@ end | |||
| (* === UCS Validators === *) | |||
|
|
|||
| module type UCS_VALIDATOR = sig | |||
| val validate : Uchar.t -> unit [@@inline] | |||
| val validate : Uchar.t -> unit | |||
There was a problem hiding this comment.
The two modules that seem to be of this type already inline this method
psafont
approved these changes
Jul 1, 2024
lindig
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still compatible with OCaml 4 too:
Printf.ksprintfexists on OCaml 4inlineattributes can be placed, OCaml 4 also accepts the new (correct) placementThere is probably going to be more once I start testing @psafont 's xapi-storage-script changes.