CP-49909: Moved install-sup-pack from scripts/plugins to python3/plugins directory #5739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ins directory - fixed bare-except and raise-missing errors Signed-off-by: Ashwinh <ashwin.h@cloud.com>
psafont
approved these changes
Jun 26, 2024
bernhardkaindl
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Details / Explanation: Also the change in line 60 is correct:
error = json.loads(str(e))[1].encode("utf8")
- except:
+ except Exception:
error = str(e)Checking it requires reading the context of the location above.
e is raised by the parent exception handler, and this exception is just a fallback for the error message.
So, I confirm the change to be correct and approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main ticket CP-49100 :Move python3 scripts from scripts directory to python3 directory.
Sub task CP-49909:
-Move install-sup-pack from scripts/plugins to python3/plugins directory
-Fix static code checker issue with respect to bare-except and raise-missing-from exception
Signed-off-by: Ashwinh ashwin.h@cloud.com