CA-394169: Allow task to have permissions on itself #5736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
reviewed
Jun 26, 2024
GabrielBuica
force-pushed
the
private/dbuica/CA-394169-fix
branch
from
8c536e1 to
1294e94
Compare
|
The CI failure is from master, fix merged here, rebase your branch: #5737 |
Do not check permissions of a task if it is acting on itself. In the case the session is lost, the task needs to be able to update itself. If the session were to be lost, we would not able to retrieve back the correct `auth_user_id`. If the task ids match implies that we know we were already authorized. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
GabrielBuica
force-pushed
the
private/dbuica/CA-394169-fix
branch
from
1294e94 to
15b6401
Compare
lindig
approved these changes
Jun 26, 2024
robhoes
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not check permissions of a task if it is acting on itself. In the case the session is lost, the task needs to be able to update itself.
If the session were to be lost, we would not able to retrieve back the correct
auth_user_id. If the task ids match implies that we know we were already authorized.