Several fixes for XenServer SDK for Go #5687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ming Lu <ming.lu@cloud.com>
Signed-off-by: Ming Lu <ming.lu@cloud.com>
psafont
approved these changes
Jun 13, 2024
Signed-off-by: Ming Lu <ming.lu@cloud.com>
Prior to this change, the function parameter list is generated by Mustache template. As a result, a template boolean variable 'first' has to be used to determine if a leading comma is presented or not. E.g. when the 'first' is true, a parameter would be rendered as "a string', and then the next parameter with the 'first' being false would be rendered as ", b string". Putting them together would result in "a string, b string". This could work but is difficult to be understood. In this commit, it is changed to construct the whole function parameter list as a string in OCaml code and bind it to the template variable 'func_params'. Similar changes apply to the template variable 'is_session_id'. It is removed in this commit and the expected values are generated by OCaml code. Signed-off-by: Ming Lu <ming.lu@cloud.com>
Signed-off-by: Ming Lu <ming.lu@cloud.com>
minglumlu
force-pushed
the
private/mingl/CP-49858
branch
from
f38387d to
deb15d6
Compare
Merged
kc284
reviewed
Jun 13, 2024
| @@ -8,10 +8,10 @@ | |||
| {{#errors}} | |||
There was a problem hiding this comment.
I don't see a licence placeholder in this file or SessionMethod.mustache, was it forgotten?
There was a problem hiding this comment.
The license placeholder is added in FileHeader.mustache. This header is for all generated .go files except jsonrpc_client.go
There was a problem hiding this comment.
I checked all generated .go files, all contained the license in file header.
xueqingz
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the comments in #5679, following changes are in this series: