Skip to content

CA-393119: Don't use HTTPS for localhost migrations #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

robhoes
Copy link
Member

@robhoes robhoes commented Jun 11, 2024

This is unnecessary overhead for traffic that does not actually hit the network.

This is unnecessary overhead for traffic that does not actually hit the
network.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Copy link
Contributor

@contificate contificate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - given the prior explanation about unnecessary stunneling being decided solely based on the URI scheme here.

@robhoes robhoes merged commit 1ea39d8 into xapi-project:master Jun 11, 2024
14 checks passed
@robhoes robhoes deleted the ca393119 branch June 11, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants